Closed
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
fix/danger
branch
3 times, most recently
from
3be4637 to
94d8eef
Compare
cortinico
reviewed
Aug 10, 2022
.github/workflows/danger_pr.yml
Outdated
Comment on lines
+29
to
+31
| env: | ||
| PUBLIC_PULLBOT_GITHUB_TOKEN_A: a6edf8e8d40ce4e8b11a | ||
| PUBLIC_PULLBOT_GITHUB_TOKEN_B: 150e1341f4dd9c944d2a |
Contributor
There was a problem hiding this comment.
Suggested change
| env: | |
| PUBLIC_PULLBOT_GITHUB_TOKEN_A: a6edf8e8d40ce4e8b11a | |
| PUBLIC_PULLBOT_GITHUB_TOKEN_B: 150e1341f4dd9c944d2a | |
| env: | |
| DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
.github/workflows/danger_pr.yml
Outdated
| working-directory: bots | ||
| - name: Danger | ||
| run: yarn danger ci --use-github-checks --failOnErrors | ||
| run: DANGER_GITHUB_API_TOKEN="$PUBLIC_PULLBOT_GITHUB_TOKEN_A""$PUBLIC_PULLBOT_GITHUB_TOKEN_B" yarn danger ci --use-github-checks --failOnErrors --id danger_pr |
Base commit: e509f96 |
Base commit: e509f96 |
cipolleschi
force-pushed
the
fix/danger
branch
from
94d8eef to
dc9c14e
Compare
cortinico
reviewed
Aug 10, 2022
.github/workflows/danger_pr.yml
Outdated
Contributor
There was a problem hiding this comment.
Also the --id danger_pr is not needed
cipolleschi
force-pushed
the
fix/danger
branch
from
dc9c14e to
ce85f4e
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 9344c7a. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: After facebook#34370, Danger started failing because the `DANGER_GITHUB_API_TOKEN` was not properly set. This PR fixes it. ## Changelog [General] [Changed] - Set back the `DANGER_GITHUB_API_TOKEN`. Pull Request resolved: facebook#34375 Test Plan: Danger GitHub action is executed correctly. Reviewed By: cortinico Differential Revision: D38571718 Pulled By: cipolleschi fbshipit-source-id: 51168098b4f910f6fefd2872f917e12daad1ec4c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #34370, Danger started failing because the
DANGER_GITHUB_API_TOKENwas not properly set.This PR fixes it.
Changelog
[General] [Changed] - Set back the
DANGER_GITHUB_API_TOKEN.Test Plan
Danger GitHub action is executed correctly.