Isolate the buck OSS commands inside test_buck#34378
Closed
cortinico wants to merge 4 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Base commit: 62021eb |
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 62021eb |
Collaborator
|
This pull request was successfully merged by @cortinico in 4699a39. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: This isolates and parallelize all the BUCK related work inside a `test_buck` job, so it's immediately clear where a failure happend. I've also added a couple of minor improvements: - Don't clone okbuck just to consume a script. I've copied the script over instead. - Removed unnecessary `buck_cache_key` This should reduce ~5 minute of build time from Test Android which was already beyond 10 minutes. ## Changelog [Internal] - Isolate the buck OSS commands inside test_buck Pull Request resolved: facebook#34378 Test Plan: Let's wait for a `test_buck` and `test_android` output. Reviewed By: cipolleschi Differential Revision: D38580359 Pulled By: cortinico fbshipit-source-id: 8b3915bbc28b4a7a169011fe9047f402c2d1f6ee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This isolates and parallelize all the BUCK related work inside a
test_buckjob, so it's immediately clear where a failure happend.I've also added a couple of minor improvements:
buck_cache_keyThis should reduce ~5 minute of build time from Test Android which was already beyond 10 minutes.
Changelog
[Internal] - Isolate the buck OSS commands inside test_buck
Test Plan
Let's wait for a
test_buckandtest_androidoutput.