Introduce the DefaultMainActivityDelegate to simplify enabling/disabling Fabric for new apps.#34446
Closed
cortinico wants to merge 1 commit into
Closed
Introduce the DefaultMainActivityDelegate to simplify enabling/disabling Fabric for new apps.#34446cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38823181 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38823181 |
cortinico
force-pushed
the
export-D38823181
branch
from
ed6e5d7 to
4e85c3f
Compare
react-native-bot
added
Platform: Android
Base commit: 4eec473 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38823181 |
cortinico
force-pushed
the
export-D38823181
branch
from
4e85c3f to
8c087d4
Compare
…ing Fabric for new apps. (facebook#34446) Summary: Pull Request resolved: facebook#34446 I'm adding another class to the .defaults package. This will take care of setting the RootView with Fabric enabled/disabled as well as controlling concurrent root. Changelog: [Android] [Added] - Introduce the DefaultMainActivityDelegate to simplify enabling/disabling Fabric for new apps. Reviewed By: cipolleschi Differential Revision: D38823181 fbshipit-source-id: a68bf1656f767f21076369f6aed2531a3302963b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38823181 |
cortinico
force-pushed
the
export-D38823181
branch
from
8c087d4 to
d1113d3
Compare
Collaborator
|
This pull request was successfully merged by @cortinico in dd6d5a7. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I'm adding another class to the .defaults package. This will take care of setting the RootView
with Fabric enabled/disabled as well as controlling concurrent root.
Changelog:
[Android] [Added] - Introduce the DefaultMainActivityDelegate to simplify enabling/disabling Fabric for new apps.
Differential Revision: D38823181