Fix ImageLoader.getSize jest mock

[elliottkember]

getSize should resolve with an array of [width, height] but this mock resolves with { width, height }.

It should be ReadOnlyArray<number> instead of {width: number, height: number}

The native image loader call is here:

  +getSize: (uri: string) => Promise<$ReadOnlyArray<number>>;

but in the jest setup file:

  getSize: jest.fn(url => Promise.resolve({width: 320, height: 240})),

Summary

My tests were failing on Image.getSize() - TypeError: Invalid attempt to destructure non-iterable instance.

I managed to trace this down to this object being returned by the Jest mock - looks like it's returning a size object instead of a dimensions array.

Workaround

If you are hitting this issue, you can work around this mock by using:

ReactNative.NativeModules.ImageLoader.getSize = jest.fn((_) => Promise.resolve([320, 240]));

Changelog

[JavaScript] [Changed]: Changed the mocked return value of ImageLoader.getSize to be [320, 240] instead of { width: 320, height: 240 }

Test Plan

TBD? I think a test with Image.getSize(path) will cover it. That's where I hit the error with the ios-specific imageLoader's getSize method.

[facebook-github-bot]

Hi @elliottkember!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,643,504	+471
android	hermes	armeabi-v7a	7,055,602	+432
android	hermes	x86	7,945,085	+500
android	hermes	x86_64	7,917,120	+416
android	jsc	arm64-v8a	9,516,021	+0
android	jsc	armeabi-v7a	8,291,634	+0
android	jsc	x86	9,455,349	+0
android	jsc	x86_64	10,046,429	+0

Base commit: 4e70376
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 4e70376
Branch: main

[facebook-github-bot]

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @elliottkember in 7be829f.

^{When will my fix make it into a release? | Upcoming Releases}