Skip to content

Remove Android.mk from internal Gradle task#34687

Closed
Sunbreak wants to merge 3 commits into
facebook:mainfrom
Sunbreak:rm-mk-from-task
Closed

Remove Android.mk from internal Gradle task#34687
Sunbreak wants to merge 3 commits into
facebook:mainfrom
Sunbreak:rm-mk-from-task

Conversation

@Sunbreak
Copy link
Copy Markdown
Contributor

Summary

Android.mks are no longer used for internal Gradle tasks since First Round of CMake files for React Android and CMake setup for ReactAndroid

Changelog

[General] [Fixed] - Remove Android.mk from internal Gradle task

Test Plan

None

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 14, 2022
@cortinico
Copy link
Copy Markdown
Contributor

Thanks for sending this @Sunbreak
Can you please update those tests that broke with your PR:

com.facebook.react.tasks.internal.PrepareBoostTaskTest > prepareBoostTask_copiesMakefile FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at com.facebook.react.tasks.internal.PrepareBoostTaskTest.prepareBoostTask_copiesMakefile(PrepareBoostTaskTest.kt:42)

com.facebook.react.tasks.internal.PrepareGlogTaskTest > prepareGlogTask_copiesMakefile FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at com.facebook.react.tasks.internal.PrepareGlogTaskTest.prepareGlogTask_copiesMakefile(PrepareGlogTaskTest.kt:42)

com.facebook.react.tasks.internal.PrepareJSCTaskTest > prepareJSCTask_copiesMakefile FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at com.facebook.react.tasks.internal.PrepareJSCTaskTest.prepareJSCTask_copiesMakefile(PrepareJSCTaskTest.kt:113)

com.facebook.react.tasks.internal.PrepareLibeventTaskTest > prepareBoostTask_copiesMakefile FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at com.facebook.react.tasks.internal.PrepareLibeventTaskTest.prepareBoostTask_copiesMakefile(PrepareLibeventTaskTest.kt:42)

95 tests completed, 4 failed

@Sunbreak
Copy link
Copy Markdown
Contributor Author

Thanks for sending this @Sunbreak Can you please update those tests that broke with your PR:

Done. Could you take another look?

@cortinico
Copy link
Copy Markdown
Contributor

Let's fix the nit and I'll import & merge this

@Sunbreak
Copy link
Copy Markdown
Contributor Author

Let's fix the nit and I'll import & merge this

Done

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Sunbreak in d0df6af.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 15, 2022
@Sunbreak Sunbreak deleted the rm-mk-from-task branch September 16, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants