Remove Android.mk from internal Gradle task#34687
Closed
Sunbreak wants to merge 3 commits into
Closed
Conversation
Contributor
|
Thanks for sending this @Sunbreak |
Contributor
Author
Done. Could you take another look? |
cortinico
approved these changes
Sep 15, 2022
Contributor
|
Let's fix the nit and I'll import & merge this |
Contributor
Author
Done |
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @Sunbreak in d0df6af. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android.mks are no longer used for internal Gradle tasks since First Round of CMake files for React Android and CMake setup for ReactAndroidChangelog
[General] [Fixed] - Remove Android.mk from internal Gradle task
Test Plan
None