Make the Android unitTests compile#34690
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
Summary: While working on another part of the codebase I realized that our Unit Tests are not compiling due to references to missing classes. I'm cleaning them up + hooking the compileTest task inside the `buildAll` task so at least they will be compiled on both CIs. Changelog: [Internal] [Changed] - Make the Android unitTests compile Reviewed By: cipolleschi Differential Revision: D39501945 fbshipit-source-id: 96a66ac5bf219742e08e5d9e035cb2e37e7e014c
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39501945 |
Collaborator
|
This pull request was successfully merged by @cortinico in 4ba9d0e. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While working on another part of the codebase I realized that
our Unit Tests are not compiling due to references to missing classes.
I'm cleaning them up + hooking the compileTest task inside the
buildAlltask so at least they will be compiled on both CIs.Changelog:
[Internal] [Changed] - Make the Android unitTests compile
Reviewed By: cipolleschi
Differential Revision: D39501945