Skip to content

Fix: Publish types folder#34727

Closed
lunaleaps wants to merge 2 commits into
facebook:mainfrom
lunaleaps:actually-package-types
Closed

Fix: Publish types folder#34727
lunaleaps wants to merge 2 commits into
facebook:mainfrom
lunaleaps:actually-package-types

Conversation

@lunaleaps
Copy link
Copy Markdown
Contributor

@lunaleaps lunaleaps commented Sep 19, 2022

Summary

From changes in #34614, I forgot to actually export the types directory.

Changelog

[Changelog][Internal] - Add types directory as part of the npm package

Test Plan

Verified on build_npm_package_1 job where we create the commitly, that types folder is included and __typetests__ are ignored

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 19, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 19, 2022

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against a61d6ca

@lunaleaps lunaleaps marked this pull request as ready for review September 19, 2022 21:32
@lunaleaps lunaleaps requested a review from hramos as a code owner September 19, 2022 21:32
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Sep 19, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,694,508 +34
android hermes armeabi-v7a 7,098,046 +36
android hermes x86 7,997,246 +23
android hermes x86_64 7,969,754 +26
android jsc arm64-v8a 9,565,094 +74
android jsc armeabi-v7a 8,332,078 +76
android jsc x86 9,505,525 +78
android jsc x86_64 10,097,156 +71

Base commit: 059e41e
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Sep 19, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 059e41e
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @lunaleaps in 6eee307.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 20, 2022
@lunaleaps lunaleaps deleted the actually-package-types branch January 19, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants