You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A moderate vulnerability was found in all versions of ws below 7.4.6 June last year. React native current uses v6.1.4 which is susceptible to it, fortunately this security fix has been backported to v6.X.X and we don't need to upgrade any major versions/worry about breaking changes. This PR bumps ws to 6.2.2 (CHANGELOG) due to this ReDoS vulnerability
More information about this vulnerability can be found here -> GHSA-6fc8-4gx4-v693
Hey @gabrieldonadel, can I ask you to rebase? The CI should be green then.
I'm also handing this over to @jacdebug for merging as ws is a quite of a tricky dependency of ours.
Hey @gabrieldonadel, can I ask you to rebase? The CI should be green then. I'm also handing this over to @jacdebug for merging as ws is a quite of a tricky dependency of ours.
Sounds good, I've just pushed a commit rebasing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Type: Security
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A moderate vulnerability was found in all versions of
wsbelow 7.4.6 June last year. React native current uses v6.1.4 which is susceptible to it, fortunately this security fix has been backported to v6.X.X and we don't need to upgrade any major versions/worry about breaking changes. This PR bumpswsto 6.2.2 (CHANGELOG) due to this ReDoS vulnerabilityMore information about this vulnerability can be found here -> GHSA-6fc8-4gx4-v693
Closes #31646
Changelog
[Internal] [Security] - Bump ws to 6.2.2 due to ReDoS vulnerability
Test Plan
Ensure WebSocket tests are working as expected