Skip to content

[Types] Sync new changes in @types/react-native (TextProps, TouchableWithoutFeedbackProps)#34794

Closed
xsjcTony wants to merge 2 commits into
facebook:mainfrom
xsjcTony:main
Closed

[Types] Sync new changes in @types/react-native (TextProps, TouchableWithoutFeedbackProps)#34794
xsjcTony wants to merge 2 commits into
facebook:mainfrom
xsjcTony:main

Conversation

@xsjcTony
Copy link
Copy Markdown
Contributor

@xsjcTony xsjcTony commented Sep 27, 2022

Summary

Sync the changes in @types/react-native DefinitelyTyped/DefinitelyTyped#62394 to here as required by @lunaleaps

Changelog

[Internal] [Added] - Sync new changes in @types/react-native

Test Plan

Tested in types/__typetests__/index.tsx

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @xsjcTony!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@xsjcTony xsjcTony changed the title Sync new changes in @types/react-native (TextProps, TouchableWithoutFeedbackProps) [Types] Sync new changes in @types/react-native (TextProps, TouchableWithoutFeedbackProps) Sep 27, 2022
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 27, 2022
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,727,438 +0
android hermes armeabi-v7a 7,130,323 +0
android hermes x86 8,033,987 +0
android hermes x86_64 8,007,274 +0
android jsc arm64-v8a 9,596,551 +0
android jsc armeabi-v7a 8,362,864 +0
android jsc x86 9,540,775 +0
android jsc x86_64 10,133,189 +0

Base commit: f85e2ec
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f85e2ec
Branch: main

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 27, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@@ -58,7 +58,7 @@ export interface TouchableWithoutFeedbackProps
/**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you forgot to update the touchSoundDisabled? as well. Was it intentional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, sorry my bad. I'll update it right now

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @xsjcTony in e0a4958.

When will my fix make it into a release? | Upcoming Releases

2 similar comments
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @xsjcTony in e0a4958.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @xsjcTony in e0a4958.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants