[Types] Sync new changes in @types/react-native (TextProps, TouchableWithoutFeedbackProps)#34794
[Types] Sync new changes in @types/react-native (TextProps, TouchableWithoutFeedbackProps)#34794xsjcTony wants to merge 2 commits into
Conversation
|
Hi @xsjcTony! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: f85e2ec |
Base commit: f85e2ec |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| @@ -58,7 +58,7 @@ export interface TouchableWithoutFeedbackProps | |||
| /** | |||
There was a problem hiding this comment.
It seems like you forgot to update the touchSoundDisabled? as well. Was it intentional?
There was a problem hiding this comment.
Ops, sorry my bad. I'll update it right now
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @xsjcTony in e0a4958. When will my fix make it into a release? | Upcoming Releases |
2 similar comments
|
This pull request was successfully merged by @xsjcTony in e0a4958. When will my fix make it into a release? | Upcoming Releases |
|
This pull request was successfully merged by @xsjcTony in e0a4958. When will my fix make it into a release? | Upcoming Releases |
Summary
Sync the changes in
@types/react-nativeDefinitelyTyped/DefinitelyTyped#62394 to here as required by @lunaleapsChangelog
[Internal] [Added] - Sync new changes in
@types/react-nativeTest Plan
Tested in
types/__typetests__/index.tsx