Fix analyze_code CircleCI Job#34801
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
Summary: D39796598 (facebook@8cdc9e7) broke this CircleCI job, causing failures for `dtslint` and `prettier`. This fixes both issues, by upating formatting, and removing types from `legacy-properties.d.ts` that we no longer export. These were not flagged by sandcastle. It looks like this is because: 1. We run eslint, but not dtslint internally 2. Arcanist will ignore anything under a "vendor" directory, while we do not exlude anything from the prettier check in OSS. I also updated the eslint config to lint any TypeScript that appears outside the types directory, since typings are now spread out. Changelog: [Internal][Fixed] - Fix `analyze_code` CircleCI Job Differential Revision: D39848604 fbshipit-source-id: 8a3b16dbbae20291c05fc7d1afea6f9423ac6474
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39848604 |
Base commit: 5933b6a |
Collaborator
|
This pull request was successfully merged by @NickGerleman in b788b6e. When will my fix make it into a release? | Upcoming Releases |
Base commit: b788b6e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D39796598 (8cdc9e7) broke this CircleCI job, causing failures for
dtslintandprettier. This fixes both issues, by upating formatting, and removing types fromlegacy-properties.d.tsthat we no longer export.These were not flagged by sandcastle. It looks like this is because:
I also updated the eslint config to lint any TypeScript that appears outside the types directory, since typings are now spread out.
Changelog:
[Internal][Fixed] - Fix
analyze_codeCircleCI JobDifferential Revision: D39848604