Skip to content

Move react_render_debug to be consumed via prefab#34802

Closed
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D39849622
Closed

Move react_render_debug to be consumed via prefab#34802
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D39849622

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
This removes the old way of consuming libreact_render_debug.so from
Android-prebuilt.cmake to using Prefab which is natively supported
by the Android pipeline.

Changelog:
[Internal] [Changed] - Move react_render_debug to be consumed via prefab

Differential Revision: D39849622

Summary:
This removes the old way of consuming `libreact_render_debug.so` from
`Android-prebuilt.cmake` to using Prefab which is natively supported
by the Android pipeline.

Changelog:
[Internal] [Changed] - Move `react_render_debug` to be consumed via prefab

Differential Revision: D39849622

fbshipit-source-id: bef0cec923c0b9d812a8a3fa14b450879df00ff8
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Sep 27, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D39849622

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,728,129 -8
android hermes armeabi-v7a 7,131,025 +4
android hermes x86 8,034,685 -2
android hermes x86_64 8,007,961 -5
android jsc arm64-v8a 9,596,927 -4
android jsc armeabi-v7a 8,363,248 +11
android jsc x86 9,541,153 -4
android jsc x86_64 10,133,551 -13

Base commit: 8dc6bec
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: bf05df1
Branch: main

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 49b14cc.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants