Fix broken template tests due to missing boost headers#34829
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39968622 |
Base commit: f164556 |
Base commit: f164556 |
Summary: Pull Request resolved: facebook#34829 I realized there is a race condition in how prefab headers are prepared and bundled. If the download of boost is not 'fast enough' the headers will be missing during prefab preparation. This fixes it. Changelog: [Internal] [Changed] - Fix broken template tests due to missing boost headers Reviewed By: cipolleschi Differential Revision: D39968622 fbshipit-source-id: 8b6a669e68f6257985151b90b088d2eb37f0ddcf
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39968622 |
cortinico
force-pushed
the
export-D39968622
branch
from
05e6e6a to
07255d6
Compare
Collaborator
|
This pull request was successfully merged by @cortinico in 98aa66a. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This unblocks the Android Template CI jobs which are currently red.
The reason is that the way how the
excludeis computed is differentbetween RN Tester and the template (relative/absolute paths).
By adding
**to the exclude regexes, this will make it work for both scenarios.Changelog:
[Internal] [Changed] - Fix broken template tests due to missing boost headers
Reviewed By: cipolleschi
Differential Revision: D39968622