Skip to content

Propagate common flag to autolinked libraries#34853

Closed
cortinico wants to merge 2 commits into
mainfrom
nc/autolinked-flags
Closed

Propagate common flag to autolinked libraries#34853
cortinico wants to merge 2 commits into
mainfrom
nc/autolinked-flags

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary

I'm handling this TODO i left to unbreak the CI.
We need to make sure all the autolinked libraries are getting the folly flags and other common flags propagated correctly.

Changelog

[Internal] [Change] - Propagate common flag to autolinked libraries

Test Plan

Will rely on a green CI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 3, 2022
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 43cf78d
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,739,292 +0
android hermes armeabi-v7a 7,141,935 +0
android hermes x86 8,050,381 +0
android hermes x86_64 8,022,197 +0
android jsc arm64-v8a 9,607,479 +0
android jsc armeabi-v7a 8,372,968 +0
android jsc x86 9,555,141 +0
android jsc x86_64 10,147,725 +0

Base commit: 43cf78d
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 06df917.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 4, 2022
@kelset kelset deleted the nc/autolinked-flags branch January 17, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants