Make yarn and yarn jest react-native-codegen works on Windows with git

[ZihanChen-MSFT]

Summary

A few fixings to make yarn jest react-native-doegen works on Windows:

• Add a .gitignore file to tell git not to track generated/temporary files.
• There is no rm on Windows, change it to rimraf.

I have been using it in the last 3 months and it works perfectly on Windows, otherwise I could not even build the code in my laptop.

Changelog

[General] [Changed] - Make yarn and yarn jest react-native-codegen works on Windows with git

Test Plan

yarn jest react-native-codegen passed

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,739,292	-348
android	hermes	armeabi-v7a	7,141,935	-195
android	hermes	x86	8,050,381	-158
android	hermes	x86_64	8,022,197	+56
android	jsc	arm64-v8a	9,607,479	-384
android	jsc	armeabi-v7a	8,372,968	-217
android	jsc	x86	9,555,141	-185
android	jsc	x86_64	10,147,725	+40

Base commit: 87acdfb
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 108c876
Branch: main

[cipolleschi]

I am a bit concerned if this works also on unix-based system. But probably yes, given that it is a node module.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[robhogan]

I am a bit concerned if this works also on unix-based system. But probably yes, given that it is a node module.

Yeah, rimraf is cross-platform

[cipolleschi]

From @robhogan

What's this about? Does react-native-codegen write into its own directory?
If this doesn't need to be in the published package then it should probably be in the root .gitignore for consistency. If it does need to be in the published package, that's a bit worrying - it should probably be using something under os.tmpdir() if it needs to write to the filesystem.

Also, we have a linting error:

Files must end in a newline.
for the .gitignore

[ZihanChen-MSFT]

@cipolleschi

it should probably be using something under os.tmpdir() if it needs to write to the filesystem.

I remember they look like generated C++ files from the unit test, I don't know why these files are not checked in or something.

The rimraf is a different thing, it removes lib which are build result.

Also, we have a linting error:

Fixed.

[cipolleschi]

I remember they look like generated C++ files from the unit test, I don't know why these files are not checked in or something.

This looks like something that only happens in Windows... Could you try again, by removing that tmp folder and see whether there are those tmp files? Perhaps it was some failed execution that left some dirt behind and we don't need to commit the .gitignore.

Also, if we need that, a better approach would be to update the .gitignore in the root folder

[ZihanChen-MSFT]

@cipolleschi Hi, looks like this commit added the tmp folder to the root .gitignore so I think I don't need to submit this file now.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @ZihanChen-MSFT in c4f9556.

^{When will my fix make it into a release? | Upcoming Releases}