Skip to content

feat(.circleci): support both architectures in rntester app #34864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hoxyq wants to merge 1 commit into from
Closed

feat(.circleci): support both architectures in rntester app #34864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,10 @@ jobs:
# -------------------------
test_ios_rntester:
executor: reactnativeios
parameters:
architecture:
type: string
default: "OldArch"
steps:
- checkout_code_with_cache
- run_yarn
Expand Down Expand Up @@ -854,9 +858,14 @@ jobs:
set_tarball_path: True
steps:
- run:
name: Install CocoaPods dependencies
name: Install CocoaPods dependencies - Architecture << parameters.architecture >>
command: |
rm -rf packages/rn-tester/Pods

if [[ << parameters.architecture >> == "NewArch" ]]; then
export RCT_NEW_ARCH_ENABLED=1
fi

cd packages/rn-tester && bundle exec pod install

- run:
Comment thread
cipolleschi marked this conversation as resolved.
Outdated
Expand Down Expand Up @@ -1466,6 +1475,9 @@ workflows:
- test_ios_rntester:
requires:
- build_hermes_macos
matrix:
parameters:
architecture: ["NewArch", "OldArch"]
- test_ios:
run_unit_tests: true
requires:
Expand Down