[Codegen]: Extract modules/schema.js from flow and TS folders to a shared file#34879
[Codegen]: Extract modules/schema.js from flow and TS folders to a shared file#34879tarunrajput wants to merge 1 commit into
Conversation
Base commit: ae3dd54 |
Base commit: ae3dd54 |
cipolleschi
left a comment
There was a problem hiding this comment.
Hi @tarunrajput, thank you for taking this. Could you also sign the CLA? We can't import this PR if you don't sign it. Thank you so much!
I've already signed it. It might take some time to update |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
/rebase |
394c777 to
8217490
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
/rebase |
8217490 to
5cd4126
Compare
|
/rebase |
5cd4126 to
6bfa660
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by Tarun Chauhan in 35556db. When will my fix make it into a release? | Upcoming Releases |
Summary
This PR reduces code duplication by
extracting the modules/schema.js from the flow and typescript folders in a shared parsers-commons.js file. Then, have the two parsers use the same wrapModuleSchema function for modulesas part of #34872Changelog
[Internal] [Changed] - Extracts the modules/schema.js from the flow and typescript folders in a shared file.
Test Plan
run

yarn jest react-native-codegen