Skip to content

[Codegen]: Extract modules/schema.js from flow and TS folders to a shared file#34879

Closed
tarunrajput wants to merge 1 commit into
facebook:mainfrom
tarunrajput:@tarunrajput/extract-codegen-parser-schema
Closed

[Codegen]: Extract modules/schema.js from flow and TS folders to a shared file#34879
tarunrajput wants to merge 1 commit into
facebook:mainfrom
tarunrajput:@tarunrajput/extract-codegen-parser-schema

Conversation

@tarunrajput
Copy link
Copy Markdown
Contributor

Summary

This PR reduces code duplication by extracting the modules/schema.js from the flow and typescript folders in a shared parsers-commons.js file. Then, have the two parsers use the same wrapModuleSchema function for modules as part of #34872

Changelog

[Internal] [Changed] - Extracts the modules/schema.js from the flow and typescript folders in a shared file.

Test Plan

run yarn jest react-native-codegen
image

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 6, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,746,762 +0
android hermes armeabi-v7a 7,148,545 +0
android hermes x86 8,057,738 +0
android hermes x86_64 8,028,677 +0
android jsc arm64-v8a 9,608,172 +0
android jsc armeabi-v7a 8,373,430 +0
android jsc x86 9,555,436 +0
android jsc x86_64 10,147,977 +0

Base commit: ae3dd54
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 6, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ae3dd54
Branch: main

Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tarunrajput, thank you for taking this. Could you also sign the CLA? We can't import this PR if you don't sign it. Thank you so much!

@tarunrajput
Copy link
Copy Markdown
Contributor Author

Hi @tarunrajput, thank you for taking this. Could you also sign the CLA? We can't import this PR if you don't sign it. Thank you so much!

I've already signed it. It might take some time to update

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 6, 2022
Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Copy Markdown
Contributor

/rebase

@github-actions github-actions Bot force-pushed the @tarunrajput/extract-codegen-parser-schema branch from 394c777 to 8217490 Compare October 7, 2022 11:26
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Copy Markdown
Contributor

/rebase

@github-actions github-actions Bot force-pushed the @tarunrajput/extract-codegen-parser-schema branch from 8217490 to 5cd4126 Compare October 7, 2022 13:05
@cipolleschi
Copy link
Copy Markdown
Contributor

/rebase

@github-actions github-actions Bot force-pushed the @tarunrajput/extract-codegen-parser-schema branch from 5cd4126 to 6bfa660 Compare October 7, 2022 13:48
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by Tarun Chauhan in 35556db.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. hacktoberfest-accepted Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants