[Codegen] Extract RootTag case of translateTypeAnnotation from the flow and typescript folders in parsers-primitives

[MaeIg]

Summary

This PR aims to reduce code duplication by extracting emitRootTag logic from the flow and typescript folders into a shared parsers-primitives file. It is a task of #34872:

Extract the content of the case 'RootTag' (Flow TypeScript) into a single emitRootTag function in the parsers-primitives.js file. Use the new function in the parsers.

Note that #34898 should be merged first. I rebased on it's branch.

Changelog

[Internal] [Changed] - Extract RootTag case of translateTypeAnnotation from the flow and typescript folders in parsers-primitives

Test Plan

All tests are passing, with yarn jest react-native-codegen:

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,747,611	+0
android	hermes	armeabi-v7a	7,149,395	+0
android	hermes	x86	8,058,588	+0
android	hermes	x86_64	8,029,524	+0
android	jsc	arm64-v8a	9,608,518	+0
android	jsc	armeabi-v7a	8,373,768	+0
android	jsc	x86	9,555,784	+0
android	jsc	x86_64	10,148,324	+0

Base commit: 54fc62c
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 54fc62c
Branch: main

[facebook-github-bot]

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

Thanks for taking this. 👏 That's amazing!

We can improve the quality even further byadding a unit test.
The steps should be:

1. add the __tests__ subfolder in the packages/react-native-codegen/src/parsers.
2. add a parser-primitives-test.js where we unit test this fuction:
   1. we test the output when the nullable parameter is false
   2. we test the output when the nullable parameter is true

An example of unit test can be found here.

Thank you so much! 🙏

[MaeIg]

Thanks for taking this. 👏 That's amazing!

We can improve the quality even further byadding a unit test. The steps should be:

1. add the __tests__ subfolder in the packages/react-native-codegen/src/parsers.

2. add a parser-primitives-test.js where we unit test this fuction:

   1. we test the output when the nullable parameter is false
   2. we test the output when the nullable parameter is true

An example of unit test can be found here.

Thank you so much! 🙏

Thanks for the review!

I thought this case was already covered in these files (flow and typescript). But you're right, it's clearer and safer to test emitRootTag function 😁

It's done if you want to re-review it!

[facebook-github-bot]

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[rshest]

@MaeIg Just a heads up - looks like there are some conflicting changes in the new main, have to be resolved before merging.

[MaeIg]

@MaeIg Just a heads up - looks like there are some conflicting changes in the new main, have to be resolved before merging.

@rshest I rebased. Thanks 🙂

[facebook-github-bot]

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @MaeIg in 5f05b07.

^{When will my fix make it into a release? | Upcoming Releases}