[Codegen]: Extract contents of the case 'NumberTypeAnnotation' into a single emitNumber function#34908
Closed
youedd wants to merge 4 commits into
Closed
[Codegen]: Extract contents of the case 'NumberTypeAnnotation' into a single emitNumber function#34908youedd wants to merge 4 commits into
youedd wants to merge 4 commits into
Conversation
Base commit: db8c11d |
Base commit: db8c11d |
rshest
suggested changes
Oct 9, 2022
Contributor
rshest
left a comment
There was a problem hiding this comment.
Great, thanks for this change!!! Would it be possible to rename parser-primitives-test.js into parsers-primitives-test.js, so that's it is consistent with the corresponding name of the file under test (parsers-primitives.js)? Thanks!
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Oct 9, 2022
rshest
approved these changes
Oct 9, 2022
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @youedd in 54fc62c. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #34872
This PR:
Changelog
[Internal] [Changed] - Extract contents of the case 'NumberTypeAnnotation' into a single emitNumber function
Test Plan
yarn jest react-native-codegen