Skip to content

Extracted MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls inside error-utils.js#34921

Closed
mohitcharkha wants to merge 4 commits into
facebook:mainfrom
mohitcharkha:extract-codegen-MoreThanOneModuleRegistryCallsParserError
Closed

Extracted MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls inside error-utils.js#34921
mohitcharkha wants to merge 4 commits into
facebook:mainfrom
mohitcharkha:extract-codegen-MoreThanOneModuleRegistryCallsParserError

Conversation

@mohitcharkha
Copy link
Copy Markdown
Contributor

Summary

This PR is part of #34872
This PR extracts MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls inside an error-utils.js file

Changelog

[Internal] [Changed] - Extracted MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls function

Test Plan

yarn jest react-native-codegen
Added unit case in the error-utils-test.js file

Extracted MoreThanOneModuleRegistryCallsParserError Test

…wIfMoreThanOneModuleRegistryCalls inside error-utils.js
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2022
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 10, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a885b1f
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 10, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,772,336 +0
android hermes armeabi-v7a 7,173,428 +0
android hermes x86 8,085,593 +0
android hermes x86_64 8,057,158 +0
android jsc arm64-v8a 9,633,511 +0
android jsc armeabi-v7a 8,397,929 +0
android jsc x86 9,582,973 +0
android jsc x86_64 10,176,011 +0

Base commit: a885b1f
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @mohitcharkha in ab22e3a.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 14, 2022
mohitcharkha added a commit to mohitcharkha/react-native that referenced this pull request Oct 17, 2022
…wIfMoreThanOneModuleRegistryCalls inside error-utils.js (facebook#34921)

Summary:
This PR is part of facebook#34872
This PR extracts MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls inside an error-utils.js file

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Internal] [Changed] - Extracted MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls function

Pull Request resolved: facebook#34921

Test Plan:
yarn jest react-native-codegen
Added unit case in the `error-utils-test.js` file

<img width="936" alt="Extracted MoreThanOneModuleRegistryCallsParserError Test" src="https://user-images.githubusercontent.com/86604753/194876724-8beec16d-4b88-4685-b8a7-a2c89208378a.png">

Reviewed By: NickGerleman

Differential Revision: D40296527

Pulled By: cipolleschi

fbshipit-source-id: 8c0d2854f42918b61ce8569cbfbaee5e90b21398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. hacktoberfest-accepted Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants