Extracted MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls inside error-utils.js#34921
Closed
mohitcharkha wants to merge 4 commits into
Conversation
…wIfMoreThanOneModuleRegistryCalls inside error-utils.js
Base commit: a885b1f |
cipolleschi
requested changes
Oct 10, 2022
Base commit: a885b1f |
cipolleschi
approved these changes
Oct 10, 2022
…gistryCallsParserError
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @mohitcharkha in ab22e3a. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
added a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
…wIfMoreThanOneModuleRegistryCalls inside error-utils.js (facebook#34921) Summary: This PR is part of facebook#34872 This PR extracts MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls inside an error-utils.js file <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extracted MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls function Pull Request resolved: facebook#34921 Test Plan: yarn jest react-native-codegen Added unit case in the `error-utils-test.js` file <img width="936" alt="Extracted MoreThanOneModuleRegistryCallsParserError Test" src="https://user-images.githubusercontent.com/86604753/194876724-8beec16d-4b88-4685-b8a7-a2c89208378a.png"> Reviewed By: NickGerleman Differential Revision: D40296527 Pulled By: cipolleschi fbshipit-source-id: 8c0d2854f42918b61ce8569cbfbaee5e90b21398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of #34872
This PR extracts MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls inside an error-utils.js file
Changelog
[Internal] [Changed] - Extracted MoreThanOneModuleRegistryCallsParserError exception to throwIfMoreThanOneModuleRegistryCalls function
Test Plan
yarn jest react-native-codegen
Added unit case in the
error-utils-test.jsfile