fix: Update incorrect SwitchChangeEvent type#34931
Closed
retyui wants to merge 1 commit into
Closed
Conversation
a868181 to
c547f86
Compare
Base commit: 14456e7 |
17 tasks
Contributor
|
hi @retyui, thanks for the fix! some of the CI tests are failing though, could you take a look? |
Contributor
|
@skinsshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lunaleaps
reviewed
Oct 11, 2022
Contributor
Author
@skinsshark nothing critical, I think a retry should fix it: CI/DS logs...// android
* What went wrong:
Execution failed for task ':react-native-gradle-plugin:compileKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':react-native-gradle-plugin:compileKotlin'
> Could not resolve all files for configuration ':react-native-gradle-plugin:compileClasspath'.
> Could not download builder-7.3.0.jar (com.android.tools.build:builder:7.3.0)
> Could not get resource 'https://dl.google.com/dl/android/maven2/com/android/tools/build/builder/7.3.0/builder-7.3.0.jar'.
> Premature end of Content-Length delimited message body (expected: 8,738,708; received: 6,029,280)
//-----------------------
// ios
Executed 173 tests, with 0 failures (0 unexpected) in 0.790 (0.845) seconds
Failing tests:
RNTesterIntegrationTests:
-[RCTLoggingTests testLogging]
-[RCTLoggingTests testLogging]
** TEST FAILED **
./IntegrationTests/launchWebSocketServer.sh: line 9: 10888 Terminated: 15 ./websocket_integration_test_server.js
~/react-native
Process terminated.
error Command failed with signal "SIGTERM". |
17357ac to
609e1cf
Compare
609e1cf to
f6b5cfd
Compare
Base commit: b33961d |
lunaleaps
approved these changes
Oct 11, 2022
Contributor
|
@skinsshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @retyui in 5dd2f2e. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
Summary:
I noticed that typescript type for `onChange` event of `<Switch/>` was incorrect
```tsx
<Switch
onChange={(event) => {
// TS
event.value; // boolean
event.nativeEvent.value; //TS2339: Property 'value' does not exist on type 'Event'.
// JS
console.log(event.nativeEvent); // {value:false,target:87}
console.log(event.value); // undefined
}}
/>
```
## Changelog
[General] [Changed] - Typescript: update incorrect `SwitchChangeEvent` type
Pull Request resolved: facebook#34931
Test Plan: ...
Reviewed By: lunaleaps
Differential Revision: D40240552
Pulled By: skinsshark
fbshipit-source-id: 4d39d547778de4ac4dc6c94471f05bfbe157d0e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that typescript type for
onChangeevent of<Switch/>was incorrectChangelog
[General] [Changed] - Typescript: update incorrect
SwitchChangeEventtypeTest Plan
...