[Codegen] Extract the function createParserErrorCapturer into a single function in the parsers/utils.js file#34934
Closed
MaeIg wants to merge 4 commits into
Closed
Conversation
…turer in a shared file
This one is a bit crazy :D
Base commit: 1fc27c4 |
Base commit: 1fc27c4 |
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
rshest
approved these changes
Oct 11, 2022
cipolleschi
approved these changes
Oct 11, 2022
Contributor
cipolleschi
left a comment
There was a problem hiding this comment.
Amazing jobs, especially with the unit tests! 👏 👏 👏
Collaborator
|
This pull request was successfully merged by @MaeIg in 38fcafe. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to reduce code duplication by extracting
createParserErrorCapturerfunction from the flow and typescript folders into a shared parsers/utils.js file. It is a task of #34872:Changelog
[Internal] [Changed] - Extract the function createParserErrorCapturer into a single function in the parsers/utils.js file
Test Plan
yarn flow:

yarn lint:

yarn jest react-native-codegen:
