[Codegen] extract emitPromise from parsers modules to shared parsers-primitives#34935
Closed
AntoineDoubovetzky wants to merge 4 commits into
Closed
Conversation
…meter to parsers-commons
Base commit: f8996f1 |
Base commit: 2f58e52 |
Contributor
|
This PR is a bit confusing, tbh... the title says one thing, but the code does at least two other things?.. :) |
Author
6e2869c to
0ead64d
Compare
Contributor
|
@AntoineDoubovetzky Ah, this makes sense, thanks for correcting the title! |
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
rshest
approved these changes
Oct 11, 2022
0ead64d to
1ce4c90
Compare
Author
|
I rebased after adding a commit to #34933 |
Collaborator
|
This pull request was successfully merged by @AntoineDoubovetzky in 966f3cd. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a task from #34872:
Note that this PR should be merged after #34933
Changelog
[Internal] [Changed] - Extract contents of the case 'Promise' into a single emitPromise function inside parsers-primitives
Test Plan
I tested using jest and flow commands.