Add more customization points in RCTAppDelegate#34943
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40262513 |
react-native-bot
added
Platform: iOS
Base commit: f353119 |
Base commit: f353119 |
Kudo
reviewed
Oct 11, 2022
Contributor
Kudo
left a comment
Kudo
left a comment
There was a problem hiding this comment.
thanks for this change, you save us a lot 🔥
Summary: Pull Request resolved: facebook#34943 The RCTAppDelegate class is the new way we have to encapsulate logic we don't want to leak to the average user. However, some advanced users, like Expo users, may need more options to customize their setup. This Diff provides more methods to extend the AppDelegate. ## Changelog [iOS][Added] - Add more extension points for RCTAppDelegate Differential Revision: D40262513 fbshipit-source-id: 49db65a99d6934c3718eb531a685e09f7ad1c633
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40262513 |
cipolleschi
force-pushed
the
export-D40262513
branch
from
b93db27 to
5183d2e
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in dd607a8. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
Summary: Pull Request resolved: facebook#34943 The RCTAppDelegate class is the new way we have to encapsulate logic we don't want to leak to the average user. However, some advanced users, like Expo users, may need more options to customize their setup. This Diff provides more methods to extend the AppDelegate. ## Changelog [iOS][Added] - Add more extension points for RCTAppDelegate Reviewed By: cortinico Differential Revision: D40262513 fbshipit-source-id: 9365a51d938a586b1508233bfa63693cf9aebf7a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The RCTAppDelegate class is the new way we have to encapsulate logic we don't want to leak to the average user.
However, some advanced users, like Expo users, may need more options to customize their setup.
This Diff provides more methods to extend the AppDelegate.
Changelog
[iOS][Added] - Add more extension points for RCTAppDelegate
Differential Revision: D40262513