Set isPressable for onPressIn/Out#34944
Closed
rozele wants to merge 1 commit into
Closed
Conversation
Summary: In react-native-windows, the ability to detect a press event on a virtual span is dependent on setting a native only `isPressable` prop. This modifies the Text component to include `onPressIn` and `onPressOut`. As a side-effect, this will also lazily initialize the pressability config when `onPressIn` or `onPressOut` only is set. Changelog: [General][Fixed] - Pressability for text with only `onPressIn` / `onPressOut` props Differential Revision: D40264432 fbshipit-source-id: 9c67bae02a4c3cb76d41e4acffe9363c8c309707
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40264432 |
Base commit: f353119 |
Base commit: f353119 |
Collaborator
|
This pull request was successfully merged by Eric Rozell in f1f7824. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been reverted by a575472. |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
Summary: Pull Request resolved: facebook#34944 In react-native-windows, the ability to detect a press event on a virtual span is dependent on setting a native only `isPressable` prop. This modifies the Text component to include `onPressIn` and `onPressOut`. As a side-effect, this will also lazily initialize the pressability config when `onPressIn` or `onPressOut` only is set. Changelog: [General][Fixed] - Pressability for text with only `onPressIn` / `onPressOut` props Reviewed By: yungsters Differential Revision: D40264432 fbshipit-source-id: 583b210127d8f020ad98030d4a5381c302e88d2a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In react-native-windows, the ability to detect a press event on a virtual span is dependent on setting a native only
isPressableprop.This modifies the Text component to include
onPressInandonPressOut. As a side-effect, this will also lazily initialize the pressability config whenonPressInoronPressOutonly is set.Changelog:
[General][Fixed] - Pressability for text with only
onPressIn/onPressOutpropsDifferential Revision: D40264432