Extracted TypeDeclarationMap from flow and typescript to a common file parsers/utils.js#34951
Closed
vinayharwani13 wants to merge 1 commit into
Closed
Extracted TypeDeclarationMap from flow and typescript to a common file parsers/utils.js#34951vinayharwani13 wants to merge 1 commit into
vinayharwani13 wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: a885b1f |
Base commit: a885b1f |
cipolleschi
approved these changes
Oct 12, 2022
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Than k you for this refactoring! 👏
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @vinayharwani13 in 2934399. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
…e parsers/utils.js (facebook#34951) Summary: This PR is a part of facebook#34872. This PR extracts TypeDeclarationMap type from flow and typescript to a common file parsers/utils.js and updates all imports. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extracted TypeDeclarationMap from flow and typescript to a common file parsers/utils.js. Pull Request resolved: facebook#34951 Test Plan: yarn jest react-native-codegen <img width="1129" alt="Screenshot 2022-10-12 at 12 13 48 PM" src="https://user-images.githubusercontent.com/87412080/195270569-fc077863-7e51-49e8-92ef-f3991f838d6a.png"> Reviewed By: NickGerleman Differential Revision: D40296917 Pulled By: cipolleschi fbshipit-source-id: d073daf0aadc291d5f9d00c003f0161af9e11319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a part of #34872.
This PR extracts TypeDeclarationMap type from flow and typescript to a common file parsers/utils.js and updates all imports.
Changelog
[Internal] [Changed] - Extracted TypeDeclarationMap from flow and typescript to a common file parsers/utils.js.
Test Plan
yarn jest react-native-codegen
