[Codegen]: extract emitMixedTypeAnnotation to parsers-commons#34954
Closed
tarunrajput wants to merge 1 commit into
Closed
[Codegen]: extract emitMixedTypeAnnotation to parsers-commons#34954tarunrajput wants to merge 1 commit into
tarunrajput wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: a885b1f |
Base commit: a885b1f |
cipolleschi
approved these changes
Oct 12, 2022
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thank you for doing this!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @tarunrajput in b87d371. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
Summary: Create a function emitMixedTypeAnnotation into the parsers-commons.js file to put together this code from [Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/modules/index.js#L400-L404) and [TypeScript](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/modules/index.js#L435-L440). Part of facebook#34872 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract emitMixedTypeAnnotation into the parsers-commons Pull Request resolved: facebook#34954 Test Plan: run ```yarn jest react-native-codegen``` <img width="781" alt="image" src="https://user-images.githubusercontent.com/34857453/195291603-f138c64c-1b49-41af-a133-ee366d02706a.png"> Reviewed By: NickGerleman Differential Revision: D40297103 Pulled By: cipolleschi fbshipit-source-id: 3ee3569fbfa850ac50df18b74ecc3eefbeb267c9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create a function emitMixedTypeAnnotation into the parsers-commons.js file to put together this code from Flow and TypeScript.
Part of #34872
Changelog
[Internal] [Changed] - Extract emitMixedTypeAnnotation into the parsers-commons
Test Plan
run
yarn jest react-native-codegen