Extracted UnsupportedFunctionReturnTypeAnnotationParserError to throwIfUnsupportedFunctionReturnTypeAnnotationParserError

[harsh-siriah]

Summary

This PR is part of #34872
This PR extracts UnsupportedFunctionReturnTypeAnnotationParserError exception to a separate function inside an error-utils.js file

Changelog

[Internal] [Changed] - Extract UnsupportedFunctionReturnTypeAnnotationParserError to a seperate function inside error-utils.js

Test Plan

yarn jest react-native-codegen

Added unit case in error-utils-test.js file

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,778,988	+0
android	hermes	armeabi-v7a	7,182,660	+0
android	hermes	x86	8,093,664	+0
android	hermes	x86_64	8,065,204	+0
android	jsc	arm64-v8a	9,637,485	+0
android	jsc	armeabi-v7a	8,403,080	+0
android	jsc	x86	9,587,446	+0
android	jsc	x86_64	10,181,002	+0

Base commit: 31f2199
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 31f2199
Branch: main

[cipolleschi]

Hi, thank you so much for taking this task! 👏

I left a very small comment on naming. A part from that, it looks good to me!

[cipolleschi]

nit: can we change the name of the parameter with just returnTypeAnnotation?
At this point, we are not discriminating between the language in the params.

Thank you so much!

[harsh-siriah]

Then should I remove the returnTypeAnnotation on line 25? Can both of them be handled from a common variable?

[cipolleschi]

I'm not sure I am following your suggestion. My comment was related to the name of the parameter we are using.
Can you expand on how will you remove the returnTypeAnnotation? Would you like to pass directly the returnTypeAnnotation.type value?

[harsh-siriah]

I have made some changes to the parameter name. I hope that works. Please let me know what you think.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @harsh-siriah in 3247436.

^{When will my fix make it into a release? | Upcoming Releases}