Extracted UnsupportedModulePropertyParserError into throwIfModuleTypeIsUnsupported function in error-utils.js file#34966
Closed
mohitcharkha wants to merge 1 commit into
Conversation
…peIsUnsupported function in error-utils.js file
facebook-github-bot
added
the
CLA Signed
Base commit: c42d824 |
Base commit: c42d824 |
cipolleschi
approved these changes
Oct 13, 2022
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Amazing, thank you so much for taking this!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @mohitcharkha in f645404. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
…IsUnsupported function in error-utils.js file (facebook#34966) Summary: This PR is part of facebook#34872 This PR extracts `UnsupportedModulePropertyParserError` exception to `throwIfModuleTypeIsUnsupported` function inside `error-utils.js` file <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract `UnsupportedModulePropertyParserError` to `throwIfModuleTypeIsUnsupported` function inside `error-utils.js` Pull Request resolved: facebook#34966 Test Plan: `yarn jest react-native-codegen` Added unit case in `error-utils-test.js` file <img width="939" alt="Screenshot 2022-10-13 at 12 14 19 PM" src="https://user-images.githubusercontent.com/86604753/195521643-6a197b51-7038-48f1-8b92-2c8c2786d66b.png"> Reviewed By: christophpurrer Differential Revision: D40337936 Pulled By: cipolleschi fbshipit-source-id: 74fb116b48634c5e3b6c11f8b71ad59f290d959e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of #34872
This PR extracts
UnsupportedModulePropertyParserErrorexception tothrowIfModuleTypeIsUnsupportedfunction insideerror-utils.jsfileChangelog
[Internal] [Changed] - Extract
UnsupportedModulePropertyParserErrortothrowIfModuleTypeIsUnsupportedfunction insideerror-utils.jsTest Plan
yarn jest react-native-codegenAdded unit case in
error-utils-test.jsfile