Extract the content of the case 'StringTypeAnnotation' into a single …#34981
Closed
ken0nek wants to merge 1 commit into
Closed
Extract the content of the case 'StringTypeAnnotation' into a single …#34981ken0nek wants to merge 1 commit into
ken0nek wants to merge 1 commit into
Conversation
…emitString function in the parsers-primitives.js file.
Base commit: a575472 |
Base commit: 8422557 |
cipolleschi
approved these changes
Oct 14, 2022
Contributor
cipolleschi
left a comment
There was a problem hiding this comment.
Amazing, thank you so much for doing this! 👏
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Oct 18, 2022
Collaborator
|
This pull request was successfully merged by @ken0nek in eda90e5. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the content of the codegen case 'String' into a single
emitStringfunction inside the parsers-primitives.js file and uses it in both Flow and TypeScript parsers as requested on #34872. This also adds unit tests to the newemitStringfunction.ref: #34936
Changelog
[Internal] [Changed] - Extract the content of the case 'StringTypeAnnotation' into a single emitString function
Test Plan
Run
yarn jest react-native-codegenand ensure CI is green