[Codegen] Extract the switch(configType) block from the buildSchema function into a new function in the parsers/utils.js file

[MaeIg]

Summary

This PR aims to extract the switch(configType) block from the buildSchema function into a separate function in a shared file between typescript and flow. It is a task of #34872:

This task is more advanced than the others. Extract the switch(configType) block (Flow, TypeScript) from the buildSchema function into a new function in the parsers/utils.js file and use it in the two functions. Note that the new function must accept some callbacks to wrapModule/ComponentSchema and to buildModule/ComponentSchema.

Changelog

[Internal] [Changed] - Extract the switch(configType) block from the buildSchema function into a new function in the parsers/utils.js file

Test Plan

yarn flow:

yarn lint:

yarn jest react-native-codegen:

I added new tests:

[MaeIg]

Hi @cipolleschi,

As requested in the task, I put buildComponentSchema, wrapComponentSchema and buildModuleSchema as parameters of the new function. But, these 3 functions are duplicated in flow and typescript folder.

I think we should consider extracting them into parsers/parsers-commons.js as done previously (2 years ago) for wrapModuleSchema. For me, they are really easy to extract!

What do you think about it? Should I propose these tasks in the umbrella issue?

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,778,150	+0
android	hermes	armeabi-v7a	7,179,206	+0
android	hermes	x86	8,091,069	+0
android	hermes	x86_64	8,062,841	+0
android	jsc	arm64-v8a	9,637,352	+0
android	jsc	armeabi-v7a	8,401,647	+0
android	jsc	x86	9,586,544	+0
android	jsc	x86_64	10,179,709	+0

Base commit: 3c8d678
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 5e6a4c5
Branch: main

[cipolleschi]

Seems very good to me and very thanks for the tests also!

Your proposal on those extra refactoring is pretty good and, eventually, we will do that and we will add them to the umbrella issue.
The wrapModuleSchema has already been refactored. The buildModuleSchema is pretty big and, IIRC, there are other PR that are working on parts of the function. I'd rather to focus on merging all the open PRs, now, to help us in figuring out what's left to do!

I hope to add some more tasks later this week. 👍

[cipolleschi]

@MaeIg could you rebase this please? 🙏

[MaeIg]

@MaeIg could you rebase this please? 🙏

Done! 😃

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @MaeIg in 8f484c3.

^{When will my fix make it into a release? | Upcoming Releases}