CocoaPods: Split React-jsc out of React-jsi#35031
Closed
hramos wants to merge 1 commit into
Closed
Conversation
Summary: The React-jsi Pod was serving two purposes: building JSI, and configuring JavaScriptCore as the JS engine. By splitting the React-jsi Pod into React-jsi and React-jsi, we can start working towards de-coupling the JSI dependency from any particular JS engine. Pods that depended on React-jsi, now depend on React-jsi and React-jsc. One exception to this is React-hermes, which is only installed when Hermes is enabled, and thus does not require JavaScriptCore. Upcoming commits should take care of removing the React-jsc dependency when Hermes is enabled, but it is out of scope for this commit. Changelog: [iOS][Changed] - The JSC Runtime is now provided by the React-jsc Pod instead of React-jsi. Libraries that declared a dependency on React-jsi in order to specifically create a JSC runtime (`makeJSCRuntime()`) will need to add React-jsc to their dependencies. Reviewed By: dmytrorykun Differential Revision: D40442603 fbshipit-source-id: 8a956cfa7e2a8fb6d7c3d6967853cdf747ba9d91
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40442603 |
Base commit: be6f656 |
Base commit: e4b5d3e |
|
PR build artifact for b1c4fe4 is ready. |
|
PR build artifact for b1c4fe4 is ready. |
Collaborator
|
This pull request was successfully merged by @hramos in 6b129d8. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The React-jsi Pod was serving two purposes: building JSI, and configuring JavaScriptCore as the JS engine.
By splitting the React-jsi Pod into React-jsi and React-jsi, we can start working towards de-coupling the JSI dependency from any particular JS engine.
Pods that depended on React-jsi, now depend on React-jsi and React-jsc.
One exception to this is React-hermes, which is only installed when Hermes is enabled, and thus does not require JavaScriptCore.
Upcoming commits should take care of removing the React-jsc dependency when Hermes is enabled, but it is out of scope for this commit.
Changelog:
[iOS][Changed] - The JSC Runtime is now provided by the React-jsc Pod instead of React-jsi. Libraries that declared a dependency on React-jsi in order to specifically create a JSC runtime (
makeJSCRuntime()) will need to add React-jsc to their dependencies.Reviewed By: dmytrorykun
Differential Revision: D40442603