Create the Parser interface#35036
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
Summary: This diff is the base to create a polimorphic behavior for TypeScript and Flow parser. This type will allow to share a lot of code between the parsers and also to keep their differences a part. It will be the base diff/PR for further tasks in the Codegen umbrella Issue ## Changelog: [General][Added] - Parser interface to divide parser logic. Differential Revision: D40548707 fbshipit-source-id: 4f6b5e56d74b9b2d92b87dfcf36abab6cb222606
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40548707 |
react-native-bot
added
the
Type: Enhancement
Base commit: be6f656 |
Base commit: be6f656 |
|
PR build artifact for a9e7751 is ready. |
|
PR build artifact for a9e7751 is ready. |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 24, 2022
Summary: Pull Request resolved: facebook#35036 This diff is the base to create a polimorphic behavior for TypeScript and Flow parser. This type will allow to share a lot of code between the parsers and also to keep their differences a part. It will be the base diff/PR for further tasks in the Codegen umbrella Issue ## Changelog: [General][Added] - Parser interface to divide parser logic. Differential Revision: https://internalfb.com/D40548707 fbshipit-source-id: b39d5fd9c662fa678b8a5bea2c5e60b0d1eabd13
Collaborator
|
This pull request was successfully merged by @cipolleschi in 5940d25. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is the base to create a polimorphic behavior for TypeScript and Flow parser. This type will allow to share a lot of code between the parsers and also to keep their differences a part.
It will be the base diff/PR for further tasks in the Codegen umbrella Issue
Changelog:
[General][Added] - Parser interface to divide parser logic.
Differential Revision: D40548707