Skip to content

Bump the Android Docker image to 6.0 (for NDK 23)#35079

Closed
cortinico wants to merge 2 commits into
facebook:mainfrom
cortinico:export-D40675449
Closed

Bump the Android Docker image to 6.0 (for NDK 23)#35079
cortinico wants to merge 2 commits into
facebook:mainfrom
cortinico:export-D40675449

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
This bumps the Docker image for React Native Android to 6.0
shipping the NDK 23 with it, finalizing all the work needed
to support NDK 23.

Changelog:
[Internal] [Changed] - Bump the Android Docker image to 6.0 (for NDK 23)

Differential Revision: D40675449

Summary:
This bumps the Docker image for React Native Android to 6.0
shipping the NDK 23 with it, finalizing all the work needed
to support NDK 23.

Changelog:
[Internal] [Changed] - Bump the Android Docker image to 6.0 (for NDK 23)

Differential Revision: D40675449

fbshipit-source-id: e41249b655058b32e1eb4779ebbfe8a95dae1bbd
@cortinico cortinico requested a review from hramos as a code owner October 25, 2022 12:58
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 25, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D40675449

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 25, 2022

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4acf7f8

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: e9b89b5
Branch: main

@pull-bot
Copy link
Copy Markdown

PR build artifact for 3d70629 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link
Copy Markdown

PR build artifact for 3d70629 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,991,873 -70,210
android hermes armeabi-v7a 6,368,346 -98,363
android hermes x86 7,404,364 +27,686
android hermes x86_64 7,268,333 -77,141
android jsc arm64-v8a 8,858,653 -60,448
android jsc armeabi-v7a 7,596,967 -88,619
android jsc x86 8,916,473 +47,668
android jsc x86_64 9,399,771 -59,753

Base commit: e9b89b5
Branch: main

@pull-bot
Copy link
Copy Markdown

PR build artifact for 4acf7f8 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link
Copy Markdown

PR build artifact for 4acf7f8 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Copy link
Copy Markdown
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 8b8a5e0.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants