chore: Add getKeyName function to codegen Parser class#35202
chore: Add getKeyName function to codegen Parser class#35202gabrieldonadel wants to merge 3 commits into
Conversation
Base commit: 5744b21 |
Base commit: bbb3a61 |
|
PR build artifact for b8c9470 is ready. |
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
left a comment
There was a problem hiding this comment.
Amazing work, thank you for doing this! 👏
What do you think about adding a unit test for the TypeScript parser and for the Flow parser?
Now that we have some small nice functions in the Parsers, it would be nice to test them!
b8c9470 to
a9d875f
Compare
Sure @cipolleschi, that sounds like a great idea, I've just pushed a commit adding some unit tests for both Parsers. |
|
PR build artifact for a9d875fa39d128daa9573e48e5f0848ede0a89d6 is ready. |
a9d875f to
a85d874
Compare
|
PR build artifact for a85d874873b6f54d785ea4f26636b997ff2f3320 is ready. |
|
PR build artifact for 518ef9ad244eed7671fd28f65e37a774fe9e911a is ready. |
03fd22c to
858fc41
Compare
858fc41 to
68f987d
Compare
|
PR build artifact for 68f987d is ready. |
|
Hi @cipolleschi everything should've been updated now, do you mind taking another look? |
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary
This PR adds a
getKeyNamefunction to the codegen Parser class and implements it in the Flow and TypeScript parsers as requested on #34872.Changelog
[Internal] [Added] - Add
getKeyNamefunction to codegen Parser classTest Plan
Run
yarn jest react-native-codegenand ensure CI is green