[codegen]: implement checkIfInvalidModule in parsers#35261
Closed
tarunrajput wants to merge 1 commit into
Closed
Conversation
Base commit: ea1d729 |
cipolleschi
approved these changes
Nov 8, 2022
Contributor
cipolleschi
left a comment
There was a problem hiding this comment.
Thank you so much for taking care of this!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
xd |
Base commit: ea1d729 |
|
PR build artifact for 5109c81 is ready. |
|
PR build artifact for 5109c81 is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the Codegen umbrella Issue #34872
Changelog
[Internal] [Added] - Add checkIfInvalidModule in the Parser interface and implement it in both parsers. Refactor throwIfIncorrectModuleRegistryCallTypeParameterParserError to use this new function.
Test Plan
Run yarn jest react-native-codegen
