Skip to content

[codegen] move remapUnionTypeAnnotationMemberNames to Parser#35314

Closed
youedd wants to merge 1 commit into
facebook:mainfrom
youedd:chore/refactor-remap-union-type-annotation-member-names
Closed

[codegen] move remapUnionTypeAnnotationMemberNames to Parser#35314
youedd wants to merge 1 commit into
facebook:mainfrom
youedd:chore/refactor-remap-union-type-annotation-member-names

Conversation

@youedd
Copy link
Copy Markdown
Contributor

@youedd youedd commented Nov 11, 2022

Summary

Part of #34872 (comment)

[Assigned to @youedd] Create a new function remapUnionTypeAnnotationMemberNames in the parser.js file and add documentation to it. Implement it properly in the FlowParser.js and in the TypeScriptParser.js. Remove the function remapUnionTypeAnnotationMemberNames and update the emitUnionTypeAnnotation signature to accept a Parser parameter instead of a language one. Use the new Parser function instead of the old one here.

Changelog

[Internal] [changed] - move remapUnionTypeAnnotationMemberNames to the parsers implementations

Test Plan

yarn jest react-native-codegen

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2022
@youedd youedd force-pushed the chore/refactor-remap-union-type-annotation-member-names branch from 0c4c05f to ca1a85e Compare November 11, 2022 17:10
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 11, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,100,944 +0
android hermes armeabi-v7a 6,470,646 +0
android hermes x86 7,518,793 +0
android hermes x86_64 7,377,397 +0
android jsc arm64-v8a 8,965,032 +0
android jsc armeabi-v7a 7,696,430 +0
android jsc x86 9,027,537 +0
android jsc x86_64 9,505,668 +0

Base commit: f657d29
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 11, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f657d29
Branch: main

@pull-bot
Copy link
Copy Markdown

PR build artifact for ca1a85e6ec77ef9ae4808029e618bc3d7347cbe6 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link
Copy Markdown

PR build artifact for ca1a85e6ec77ef9ae4808029e618bc3d7347cbe6 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, it looks very good to me! :D

@cipolleschi
Copy link
Copy Markdown
Contributor

Could you rebase to solve conflicts? 🙏

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@youedd youedd force-pushed the chore/refactor-remap-union-type-annotation-member-names branch from ca1a85e to 9aac210 Compare November 12, 2022 18:09
@youedd
Copy link
Copy Markdown
Contributor Author

youedd commented Nov 12, 2022

@cipolleschi it's rebased !

@pull-bot
Copy link
Copy Markdown

PR build artifact for 9aac210 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link
Copy Markdown

PR build artifact for 9aac210 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants