Enable C++17 for cxxreact and jsiexecutor/inspector and ...#35435
Closed
christophpurrer wants to merge 1 commit into
Closed
Enable C++17 for cxxreact and jsiexecutor/inspector and ...#35435christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary: This raises the C++ language standard to C++17 which is needed to remove some folly:: dependencies changelog: [Internal] Differential Revision: D41482821 fbshipit-source-id: e39c68948b36430338af5a2d8a52f1988e483881
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41482821 |
Base commit: 0d3d002 |
Base commit: 6410a62 |
|
PR build artifact for 1e62463 is ready. |
cortinico
approved these changes
Nov 23, 2022
Collaborator
|
This pull request was successfully merged by @christophpurrer in 9517320. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This raises the C++ language standard to C++17 which is needed to remove some folly:: dependencies
changelog: [Internal]
Differential Revision: D41482821