Skip to content

Replace folly::Optional with std::optional#35436

Closed
christophpurrer wants to merge 1 commit into
facebook:mainfrom
christophpurrer:export-D41415031
Closed

Replace folly::Optional with std::optional#35436
christophpurrer wants to merge 1 commit into
facebook:mainfrom
christophpurrer:export-D41415031

Conversation

@christophpurrer
Copy link
Copy Markdown
Contributor

Summary:
Using std::optional as react-native has been using C++17 for quite some time

changelog: [Internal]

Differential Revision: D41415031

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 22, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41415031

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 22, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,102,660 -873
android hermes armeabi-v7a 6,471,373 -484
android hermes x86 7,520,833 -335
android hermes x86_64 7,379,499 -555
android jsc arm64-v8a 8,967,652 -707
android jsc armeabi-v7a 7,698,978 -489
android jsc x86 9,030,332 -326
android jsc x86_64 9,507,964 -726

Base commit: a672869
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 22, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a672869
Branch: main

@pull-bot
Copy link
Copy Markdown

PR build artifact for 372f96eb00c0c9ade1405e7a6664b4293715be02 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! I've checked the CMake part and the code looks generally fine to me 👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41415031

@pull-bot
Copy link
Copy Markdown

PR build artifact for d79d4359985c4209614cd74b9d2cccfedc03def9 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Summary:
Pull Request resolved: facebook#35436

Using std::optional as react-native has been using C++17 for quite some time

changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D41415031

fbshipit-source-id: 8165a4f1b24c49c58fcb5af59a50f31e96816cc4
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41415031

@pull-bot
Copy link
Copy Markdown

PR build artifact for 0c1ca87 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @christophpurrer in 022e22c.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants