Replace folly::Optional with std::optional#35436
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D41415031 |
Base commit: a672869 |
Base commit: a672869 |
|
PR build artifact for 372f96eb00c0c9ade1405e7a6664b4293715be02 is ready. |
cortinico
left a comment
There was a problem hiding this comment.
Awesome stuff! I've checked the CMake part and the code looks generally fine to me 👍
|
This pull request was exported from Phabricator. Differential Revision: D41415031 |
372f96e to
d79d435
Compare
|
PR build artifact for d79d4359985c4209614cd74b9d2cccfedc03def9 is ready. |
Summary: Pull Request resolved: facebook#35436 Using std::optional as react-native has been using C++17 for quite some time changelog: [Internal] Reviewed By: cortinico Differential Revision: D41415031 fbshipit-source-id: 8165a4f1b24c49c58fcb5af59a50f31e96816cc4
|
This pull request was exported from Phabricator. Differential Revision: D41415031 |
d79d435 to
0c1ca87
Compare
|
PR build artifact for 0c1ca87 is ready. |
|
This pull request was successfully merged by @christophpurrer in 022e22c. When will my fix make it into a release? | Upcoming Releases |
Summary:
Using std::optional as react-native has been using C++17 for quite some time
changelog: [Internal]
Differential Revision: D41415031