Skip to content

[Codegen] Move emitUnionTypeAnnotation into parsers-primitives#35502

Closed
MaeIg wants to merge 2 commits into
facebook:mainfrom
MaeIg:refactor/move-emitUnionTypeAnnotation
Closed

[Codegen] Move emitUnionTypeAnnotation into parsers-primitives#35502
MaeIg wants to merge 2 commits into
facebook:mainfrom
MaeIg:refactor/move-emitUnionTypeAnnotation

Conversation

@MaeIg
Copy link
Copy Markdown
Contributor

@MaeIg MaeIg commented Nov 29, 2022

Summary

This PR aims to move the emitUnionTypeAnnotation function into parsers-primitives.
It was extracted to parsers-commons in a task of #34872. But, all other emit* functions are in this file, so I think it was a mistake.

Changelog

[Internal] [Changed] - Move emitUnionTypeAnnotation function into parsers-primitives

Test Plan

yarn flow:
image

yarn lint:
image

yarn test:
image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 29, 2022
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 29, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2db26c5
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 29, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,096,963 +0
android hermes armeabi-v7a 6,466,006 +0
android hermes x86 7,515,055 +0
android hermes x86_64 7,373,440 +0
android jsc arm64-v8a 8,962,052 +0
android jsc armeabi-v7a 7,693,675 +0
android jsc x86 9,024,635 +0
android jsc x86_64 9,502,137 +0

Base commit: 2db26c5
Branch: main

Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking care of this cleanup. It was my mistake in listing the task in the issue! 🙏

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pull-bot
Copy link
Copy Markdown

PR build artifact for e8452cc227278d849921c4d1c6d836d4a4bade4e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link
Copy Markdown

PR build artifact for e8452cc227278d849921c4d1c6d836d4a4bade4e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@MaeIg MaeIg force-pushed the refactor/move-emitUnionTypeAnnotation branch from e8452cc to ee7fd8a Compare November 30, 2022 15:33
@MaeIg
Copy link
Copy Markdown
Contributor Author

MaeIg commented Nov 30, 2022

Hello @cipolleschi!
I rebased on main and resolved conflicts. Maybe this one is mergeable? I believe that the internal linter was green

This is to stay consistent with the other functions of parsers-primitives
@MaeIg MaeIg force-pushed the refactor/move-emitUnionTypeAnnotation branch from ee7fd8a to 466f009 Compare November 30, 2022 16:35
@pull-bot
Copy link
Copy Markdown

PR build artifact for 466f009 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link
Copy Markdown

PR build artifact for 466f009 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2022

This pull request was successfully merged by @MaeIg in ee8701e.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions Bot added the Merged This PR has been merged. label Dec 1, 2022
@MaeIg MaeIg deleted the refactor/move-emitUnionTypeAnnotation branch December 1, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants