[Codegen] Move emitUnionTypeAnnotation into parsers-primitives#35502
[Codegen] Move emitUnionTypeAnnotation into parsers-primitives#35502MaeIg wants to merge 2 commits into
Conversation
Base commit: 2db26c5 |
Base commit: 2db26c5 |
cipolleschi
left a comment
There was a problem hiding this comment.
Thank you so much for taking care of this cleanup. It was my mistake in listing the task in the issue! 🙏
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
PR build artifact for e8452cc227278d849921c4d1c6d836d4a4bade4e is ready. |
|
PR build artifact for e8452cc227278d849921c4d1c6d836d4a4bade4e is ready. |
e8452cc to
ee7fd8a
Compare
|
Hello @cipolleschi! |
This is to stay consistent with the other functions of parsers-primitives
ee7fd8a to
466f009
Compare
|
PR build artifact for 466f009 is ready. |
|
PR build artifact for 466f009 is ready. |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @MaeIg in ee8701e. When will my fix make it into a release? | Upcoming Releases |
Summary
This PR aims to move the emitUnionTypeAnnotation function into parsers-primitives.
It was extracted to parsers-commons in a task of #34872. But, all other emit* functions are in this file, so I think it was a mistake.
Changelog
[Internal] [Changed] - Move emitUnionTypeAnnotation function into parsers-primitives
Test Plan
yarn flow:

yarn lint:

yarn test:
