Skip to content

Add ability to schedule JS functions as tasks from turbo modules#35525

Closed
rshest wants to merge 1 commit into
facebook:mainfrom
rshest:export-D41492849
Closed

Add ability to schedule JS functions as tasks from turbo modules#35525
rshest wants to merge 1 commit into
facebook:mainfrom
rshest:export-D41492849

Conversation

@rshest
Copy link
Copy Markdown
Contributor

@rshest rshest commented Dec 1, 2022

Summary:
[Changelog][Internal]

Adds ability to invoke an async JS callback from a C++ native module, as a task with priority.

This will allow native modules to schedule less important calls to JS thread with lower priority. One example use case is feeding collected perf metrics back to JS.

Reviewed By: javache

Differential Revision: D41492849

Summary:
[Changelog][Internal]

Adds ability to invoke an async JS callback from a C++ native module, as a task with priority.

This will allow native modules to schedule less important calls to JS thread with lower priority. One example use case is feeding collected perf metrics back to JS.

Reviewed By: javache

Differential Revision: D41492849

fbshipit-source-id: 99758ee9deb4c5c4b6f9dd2ac329126754df396d
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 1, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D41492849

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2022

Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 1bbc1f2

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,099,783 +1,645
android hermes armeabi-v7a 6,468,574 +1,397
android hermes x86 7,518,002 +1,764
android hermes x86_64 7,376,367 +1,916
android jsc arm64-v8a 8,964,767 +1,652
android jsc armeabi-v7a 7,696,162 +1,413
android jsc x86 9,027,471 +1,758
android jsc x86_64 9,504,960 +1,914

Base commit: da4243b
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: da4243b
Branch: main

@pull-bot
Copy link
Copy Markdown

pull-bot commented Dec 1, 2022

PR build artifact for 1bbc1f2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link
Copy Markdown

pull-bot commented Dec 1, 2022

PR build artifact for 1bbc1f2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2022

This pull request was successfully merged by Ruslan Shestopalyuk in e2c4941.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions Bot added the Merged This PR has been merged. label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants