Skip to content

fix: script phases warning#35594

Closed
matinzd wants to merge 1 commit into
facebook:mainfrom
matinzd:patch-1
Closed

fix: script phases warning#35594
matinzd wants to merge 1 commit into
facebook:mainfrom
matinzd:patch-1

Conversation

@matinzd
Copy link
Copy Markdown
Contributor

@matinzd matinzd commented Dec 7, 2022

Summary

Running pod install result in some warninigs on ruby v3:

script_phases.rb:51: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
script_phases.rb:51: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

Changelog

[INTERNAL] [FIXED] - warnings while running pod-install inside script phase script

Test Plan

  • Install ruby v3 (I haven't tested on ruby v2.7, most m1 users need to upgrade to v3)
  • Run pod install in ios folder

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 7, 2022
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,109,976 +0
android hermes armeabi-v7a 6,479,023 +0
android hermes x86 7,528,944 +0
android hermes x86_64 7,387,129 +0
android jsc arm64-v8a 8,977,559 +0
android jsc armeabi-v7a 7,708,943 +0
android jsc x86 9,040,680 +0
android jsc x86_64 9,517,974 +0

Base commit: 5928144
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5928144
Branch: main

@pull-bot
Copy link
Copy Markdown

pull-bot commented Dec 8, 2022

PR build artifact for 66ab1bb is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@cortinico
Copy link
Copy Markdown
Contributor

Install ruby v3 (I haven't tested on ruby v2, most m1 users need to upgrade to v3)

I'm wondering why this is needed as RN is pinned on Ruby 2.7?

@matinzd
Copy link
Copy Markdown
Contributor Author

matinzd commented Dec 8, 2022

Install ruby v3 (I haven't tested on ruby v2, most m1 users need to upgrade to v3)

I'm wondering why this is needed as RN is pinned on Ruby 2.7?

This change will also work for 2.7. I would suggest using newly named arguments to avoid any future issues when they got deprecated and we bumped the ruby version.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 8, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in 48966eb.

@matinzd matinzd deleted the patch-1 branch December 9, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants