Skip to content

ci: Add unsupported-version label action#35849

Closed
blakef wants to merge 1 commit intofacebook:mainfrom
blakef:export-D42531703
Closed

ci: Add unsupported-version label action#35849
blakef wants to merge 1 commit intofacebook:mainfrom
blakef:export-D42531703

Conversation

@blakef
Copy link
Copy Markdown
Contributor

@blakef blakef commented Jan 16, 2023

Summary:
Users will provide issues or examples that use unsupported versions of React Native. Provide label to track and ask them to update example / issue to currently mainted version.

Changelog:

[Internal] - Support 'unsupported version' tag comment

Differential Revision: D42531703

image

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jan 16, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D42531703

@blakef
Copy link
Copy Markdown
Contributor Author

blakef commented Jan 16, 2023

Does anyone here have strong opinion over whether we close this immediately on the label being assigned or add the Needs: Author Feedback label (and stale bot will take care of neglected issues in +187 days)?

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jan 16, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,465,533 +0
android hermes armeabi-v7a 7,786,280 +0
android hermes x86 8,939,013 +0
android hermes x86_64 8,797,083 +0
android jsc arm64-v8a 9,650,654 +0
android jsc armeabi-v7a 8,385,129 +0
android jsc x86 9,712,847 +0
android jsc x86_64 10,190,031 +0

Base commit: e6d1ab9
Branch: main

@iBotPeaches
Copy link
Copy Markdown
Contributor

Does anyone here have strong opinion over whether we close this immediately on the label being assigned or add the Needs: Author Feedback label (and stale bot will take care of neglected issues in +187 days)?

I'd close it, no need to have an unsupported ticket staying around for 190~ days.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D42531703

Summary:
Pull Request resolved: #35849

Users will provide issues or examples that use unsupported versions of React Native. Provide label to track and ask them to update example / issue to currently mainted version.

Changelog:

[Internal] - Support 'unsupported version' tag comment

Differential Revision: D42531703

fbshipit-source-id: 7aa609ab993989b22e8275b07457765ef52a4d76
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D42531703

@blakef
Copy link
Copy Markdown
Contributor Author

blakef commented Jan 17, 2023

Does anyone here have strong opinion over whether we close this immediately on the label being assigned or add the Needs: Author Feedback label (and stale bot will take care of neglected issues in +187 days)?

I'd close it, no need to have an unsupported ticket staying around for 190~ days.

Added closing out any issue / PR tagged with Needs: Author Feedback after 31 days of inactivity (with a reminder after 24 days).

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 17, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 474c0ed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants