save registry auth token before bootstrapping verdaccio#35991
Closed
hoxyq wants to merge 1 commit intofacebook:mainfrom
Closed
save registry auth token before bootstrapping verdaccio#35991hoxyq wants to merge 1 commit intofacebook:mainfrom
hoxyq wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [Internal] While cherry-picking all this logic to `0.71-stable` branch, we've discovered several issues where some packages were failing to be published on Verdaccio proxy This was failing only on node v16+, after some research, I've noticed that there might be a race-condition and npm unable to grab this token before first `npm publish` executes Although this still work well on `main` branch, I am backporting it to keep aligned with `0.71-stable` Differential Revision: D42806081 fbshipit-source-id: 1832e040dbb33aea7500ad016016c7a20be4e19f
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42806081 |
Base commit: a00cea4 |
cortinico
approved these changes
Jan 27, 2023
|
This pull request was successfully merged by @hoxyq in 8d5f880. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
While cherry-picking all this logic to
0.71-stablebranch, we've discovered several issues where some packages were failing to be published on Verdaccio proxyThis was failing only on node v16+, after some research, I've noticed that there might be a race-condition and npm unable to grab this token before first
npm publishexecutesAlthough this still work well on
mainbranch, I am backporting it to keep aligned with0.71-stableDifferential Revision: D42806081