Skip to content

Fix displayed name when codegen dependency is not found #36013

Closed
krystofwoldrich wants to merge 1 commit into
facebook:mainfrom
krystofwoldrich:fix-codegen-package-name-artifacts-executor
Closed

Fix displayed name when codegen dependency is not found #36013
krystofwoldrich wants to merge 1 commit into
facebook:mainfrom
krystofwoldrich:fix-codegen-package-name-artifacts-executor

Conversation

@krystofwoldrich
Copy link
Copy Markdown
Contributor

@krystofwoldrich krystofwoldrich commented Jan 31, 2023

Summary

The fixed error guides users toward the right missing dependency. The original error pointed to the old name.

Changelog

[INTERNAL] [FIXED] - Display correct codegen dependency name when not found

Test Plan

This is an error message wording change.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,463,548 +0
android hermes armeabi-v7a 7,783,963 +0
android hermes x86 8,936,622 +0
android hermes x86_64 8,794,661 +0
android jsc arm64-v8a 9,648,959 +0
android jsc armeabi-v7a 8,383,226 +0
android jsc x86 9,710,923 +0
android jsc x86_64 10,187,777 +0

Base commit: 83743e1
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 31, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi merged this pull request in 86852f8.

@krystofwoldrich krystofwoldrich deleted the fix-codegen-package-name-artifacts-executor branch February 2, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants