rename module exports from "aliases" to "aliasMap"#36028
Closed
vzaidman wants to merge 1 commit into
Closed
Conversation
Summary: Use aliasMap both in parsers and generators instead of using aliasMap in half of the places and aliases in the other. This would also allow us to introduce "enumMap" more easily in the next commit. Changelog: [Internal] rename module exports from "aliases" to "aliasMap" Reviewed By: christophpurrer Differential Revision: D42888752 fbshipit-source-id: cc22908a22564c34e180192ca85c58d7010459b7
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42888752 |
Base commit: bf34810 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Feb 2, 2023
Summary: Pull Request resolved: facebook#36028 Use aliasMap both in parsers and generators instead of using aliasMap in half of the places and aliases in the other. This would also allow us to introduce "enumMap" more easily in the next commit. Changelog: [Internal] rename module exports from "aliases" to "aliasMap" Reviewed By: christophpurrer, cipolleschi Differential Revision: D42888752 fbshipit-source-id: d47c35fd649d5d4313e9436fdd57496eda53e1d4
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
Summary: Pull Request resolved: #36042 Pull Request resolved: #36028 Use aliasMap both in parsers and generators instead of using aliasMap in half of the places and aliases in the other. This would also allow us to introduce "enumMap" more easily in the next commit. Changelog: [Internal] rename module exports from "aliases" to "aliasMap" Reviewed By: christophpurrer, cipolleschi Differential Revision: D42888752 fbshipit-source-id: cf1929fcebde994d07e5c6bda5ab71106d417b21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Use aliasMap both in parsers and generators instead of using aliasMap in half of the places and aliases in the other.
This would also allow us to introduce "enumMap" more easily in the next commit.
Changelog: [Internal] rename module exports from "aliases" to "aliasMap"
Reviewed By: christophpurrer
Differential Revision: D42888752