Reduce flakyness on InteractionManager-test#36092
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
Summary: This test is partially disabled already, causing high flakyness of the `test_windows` CI job. I'm taking a different approach at disabling it here (disabling the offending tests using a `Promise` rather than disabling at the assert level). Changelog: [Internal] [Changed] - Reduce flakyness on InteractionManager-test Reviewed By: cipolleschi Differential Revision: D43120897 fbshipit-source-id: 4bfe35012384e7777ec7318d1cd4c0a61196f64b
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43120897 |
Base commit: 56cb19f |
Contributor
|
This pull request has been merged in 4128df2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This test is partially disabled already, causing high flakyness of the
test_windowsCI job.I'm taking a different approach at disabling it here (disabling the offending tests using a
Promiserather than disabling at the assert level).
Changelog:
[Internal] [Changed] - Reduce flakyness on InteractionManager-test
Reviewed By: cipolleschi
Differential Revision: D43120897