Move test-docker-android from GH Actions to CircleCI#36093
Closed
cortinico wants to merge 2 commits intofacebook:mainfrom
Closed
Move test-docker-android from GH Actions to CircleCI#36093cortinico wants to merge 2 commits intofacebook:mainfrom
cortinico wants to merge 2 commits intofacebook:mainfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43121477 |
c63a77b to
77eca58
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43121477 |
Base commit: 1c8179b |
Summary: Pull Request resolved: facebook#36093 The Test Docker Android job is flaky as sometimes fetching artifacts from remote returns different hashes. I'm moving the job to CircleCI (so it's faster) + I'm using the `buck_fetch.sh` script we already have which has a retry logic. Changelog: [Internal] [Changed] - Move test-docker-android from GH Actions to CircleCI Reviewed By: javache Differential Revision: D43121477 fbshipit-source-id: 8feec6ea2677abb95adaf93cbbeb0fa98cc7835a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43121477 |
77eca58 to
4da0c0c
Compare
Contributor
|
This pull request has been merged in 9eaf6f5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The Test Docker Android job is flaky as sometimes fetching artifacts from remote
returns different hashes.
I'm moving the job to CircleCI (so it's faster) + I'm using the
buck_fetch.shscript we already have which has a retry logic.
Changelog:
[Internal] [Changed] - Move test-docker-android from GH Actions to CircleCI
Differential Revision: D43121477