Hardcode concurrentRootEnabled to true when Fabric is enabled#36106
Closed
cipolleschi wants to merge 1 commit into
Closed
Hardcode concurrentRootEnabled to true when Fabric is enabled#36106cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
Summary: Having `concurrentRoot` disabled when Fabric is enabled is not recommended. This simplifies the setup and makes sure that both are either enabled or disabled. ## Changelog: [iOS] [Breaking] - Hardcode concurrentRootEnabled to `true` when Fabric is enabled Differential Revision: D43153402 fbshipit-source-id: 85eb59d434170a9c5ece08023bc40ce8d0453586
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43153402 |
Base commit: 23607ae |
Contributor
|
This pull request has been merged in 7eaabfb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Having
concurrentRootdisabled when Fabric is enabled is not recommended.This simplifies the setup and makes sure that both are either enabled or disabled.
Changelog:
[iOS] [Breaking] - Hardcode concurrentRootEnabled to
truewhen Fabric is enabledDifferential Revision: D43153402