Skip to content

Missing src, srcSet, referrerPolicy, tintColor on Image.d.ts #36214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alvessteve wants to merge 4 commits into from
Closed

Missing src, srcSet, referrerPolicy, tintColor on Image.d.ts #36214

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4d7af4
fix(image-types): add missing tintColor on .d.ts file
alvessteve Feb 18, 2023
b4d9da9
fix(image-types): add missing referrerPolicy on .d.ts file
alvessteve Feb 18, 2023
aece29f
fix(image-types): add missing src prop on .d.ts file
alvessteve Feb 18, 2023
9c9e2de
fix(image-types): add missing srcSet prop on .d.ts file
alvessteve Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion Libraries/Image/Image.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {Constructor} from '../../types/private/Utilities';
import {AccessibilityProps} from '../Components/View/ViewAccessibility';
import {Insets} from '../../types/public/Insets';
import {NativeMethods} from '../../types/public/ReactNativeTypes';
import {StyleProp} from '../StyleSheet/StyleSheet';
import {ColorValue, StyleProp} from '../StyleSheet/StyleSheet';
import {ImageStyle, ViewStyle} from '../StyleSheet/StyleSheetTypes';
import {LayoutChangeEvent, NativeSyntheticEvent} from '../Types/CoreEventTypes';
import {ImageResizeMode} from './ImageResizeMode';
Expand Down Expand Up @@ -225,6 +225,21 @@ export interface ImagePropsBase
*/
source: ImageSourcePropType;

/**
* A string representing the resource identifier for the image. Similar to
* src from HTML.
*
* See https://reactnative.dev/docs/image#src
*/
src?: string | undefined,

/**
* Similar to srcset from HTML.
*
* See https://reactnative.dev/docs/image#srcset
*/
srcSet?: string | undefined,

/**
* similarly to `source`, this property represents the resource used to render
* the loading indicator for the image, displayed until image is ready to be
Expand Down Expand Up @@ -276,6 +291,28 @@ export interface ImagePropsBase
* See https://reactnative.dev/docs/image#crossorigin
*/
crossOrigin?: 'anonymous' | 'use-credentials';

/**
* Changes the color of all the non-transparent pixels to the tintColor.
*
* See https://reactnative.dev/docs/image#tintcolor
*/
tintColor?: ColorValue | undefined,

/**
* A string indicating which referrer to use when fetching the resource.
* Similar to referrerpolicy from HTML.
*
* See https://reactnative.dev/docs/image#referrerpolicy
*/
referrerPolicy?: 'no-referrer'
| 'no-referrer-when-downgrade'
| 'origin'
| 'origin-when-cross-origin'
| 'same-origin' | 'strict-origin'
| 'strict-origin-when-cross-origin'
| 'unsafe-url'
| undefined,
}

export interface ImageProps extends ImagePropsBase {
Expand Down