[Upstream] Import OCMock as a pod for RNTester on iOS#36239
Conversation
Base commit: a49446b |
cipolleschi
left a comment
There was a problem hiding this comment.
Hi @Saadnajmi, could you please resolve the conflicts on the Podfile.lock?
Also, please revert the changes to the RNTesterPods.xcodeproj/project.pbxproj as those changes should be applied by the cocoapod script and should not be checked in.
I'll then import the PR as it looks like that everything is green and it allow us to remove a bunch of files (which translates to less maintenance burden... so that's really good!)
Thank you so much for doing this!
Thanks for the catch! I didn't notice my pbxproj changes were unrelated, oof. The latest iteration should be clean :). Also thanks also goes to @amgleitman who did this change originally on our fork. |
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for polishing this up
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in d00c150. |
Summary: In #36239 , I removed the copy of libOCMock we had locally in favor of a Pod. The references were left in RNTester's pbxproj and undefined. Let's just remove them. ## Changelog: [INTERNAL] [FIXED] - Remove undefined references to OCMock from RNTesters' pbxproj Pull Request resolved: #39616 Test Plan: CI should pass Reviewed By: NickGerleman Differential Revision: D49612102 Pulled By: ryancat fbshipit-source-id: 85a5a67612dc58d5dba906edc1c56091d22b0978
Summary
This is a change we have implemented in React Native macOS that I am now upstreaming: microsoft#1257
The library
ocMockis currently imported as a checked in binary by RN-Tester to help run unit tests on iOS. That binary is only compiled for x86 on macOS, which meant we could not run tests on M1 / M2 Macs. Switching it so that we import from source as a pod should make maintenance easier for both iOS and macOS! :)Original change notes:
Changelog
[INTERNAL] [CHANGED] - Import OCMock as a pod
Test Plan
CI should pass as it did before.